Skip to content

Conversation

huanlin
Copy link
Contributor

@huanlin huanlin commented Jul 2, 2024

Firstly, thank you all for the hard work!
Secondly, I'd like say that I'm no expert in Hugo, Docsy, and JavaScript. Therefore, this is more of a proposition for fixing issue #257.

After discussing with prdsoftware, I realized that the fix must also take into account the sidebar_cache_limit option in the Hugo config file. So I implemented the fix in /layouts/partials/sidebar.html, and I've tested it on my website with side bar cache both enabled and disabled.

If there is anything that I've missed. Kindly let me know how to improve. Thanks!

@fekete-robert
Copy link
Contributor

LGTM, thanks a lot!

@fekete-robert fekete-robert self-requested a review August 3, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants