Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Edit pruneCss flag to allow printing pruned css instead of overwriting. #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MonamAgarwal
Copy link
Contributor

This will enable user to see the pruned CSS and them make changes according to their own requirements.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@@ -121,7 +121,7 @@ Examples: see [example/angular1](https://github.com/google/dart-scissors/tree/ma
```

Valid settings:
- `pruneCss` (boolean): by default, `true` in `release` only
- `pruneCss` (`skip` or `print` or `overwrite`): by default, `overwrite` in `release` only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, can you deprecate the existing flag and add a new one? I found 1 existing usage of pruneCss with a bool value, this would break it.

Alternatively, we can keep it and accept true, false, warnOnly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Olivier.
Can you please point me to existing usage of pruneCss. Because AFAIS I have replaced all the usages. So this should work fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you please document each enum value in the readme with the same format as the other enums?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants