Skip to content

Conversation

sboni-sc
Copy link

@sboni-sc sboni-sc commented May 7, 2025

JIra Watcher Management Improvements

  • Enhanced _add_watchers method to prevent duplicate watcher additions. This is essential because if there are a lot of watchers and jira tickets this could amount to a huge load of unnecessary requests when we are updating these tickets for unrelated fields.
  • Added error handling for watcher addition failures
  • Improved efficiency by checking existing watchers before making API calls

Copy link

google-cla bot commented May 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sboni-sc
Copy link
Author

sboni-sc commented May 7, 2025

ptal @jonathanmetzman @vitorguidi

Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman
Copy link
Collaborator

/gcbrun

@jonathanmetzman
Copy link
Collaborator

Interesting, what are you using this to fuzz?

@jonathanmetzman
Copy link
Collaborator

Please run formatter.

@sboni-sc
Copy link
Author

Ran formatter on the code: 405f4af

We are running this internally for our organization. While we don't have a large volume of tickets, the current approach has been causing issues. Specifically, some of the cron jobs frequently trigger update watcher requests, which result in a significant number of requests being sent to Jira. This high volume of requests is effectively contributing to the overwhelming of Jira, leading to it being locked for updates and writes.

@jonathanmetzman
Copy link
Collaborator

/gcbrun

Copy link

This pull request has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions bot added the stale label Jul 29, 2025
Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman
Copy link
Collaborator

/gbcurn

@jonathanmetzman
Copy link
Collaborator

Sorry I was on paternity leave.

@github-actions github-actions bot removed the stale label Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants