-
Notifications
You must be signed in to change notification settings - Fork 586
Update issue_tracker_manager.py #4788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/gcbrun |
Interesting, what are you using this to fuzz? |
Please run formatter. |
Ran formatter on the code: 405f4af We are running this internally for our organization. While we don't have a large volume of tickets, the current approach has been causing issues. Specifically, some of the cron jobs frequently trigger update watcher requests, which result in a significant number of requests being sent to Jira. This high volume of requests is effectively contributing to the overwhelming of Jira, leading to it being locked for updates and writes. |
/gcbrun |
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/gbcurn |
Sorry I was on paternity leave. |
JIra Watcher Management Improvements
_add_watchers
method to prevent duplicate watcher additions. This is essential because if there are a lot of watchers and jira tickets this could amount to a huge load of unnecessary requests when we are updating these tickets for unrelated fields.