Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont enforce a 25 second timeout. #4607

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Dont enforce a 25 second timeout. #4607

merged 1 commit into from
Jan 15, 2025

Conversation

jonathanmetzman
Copy link
Collaborator

This was requested by chrome. I can't really think of a strong justification for this paternalistic behavior, and I can think of some against it, mainly that it causes CF to behave unlike the user expects.

Fixes: b/382207330

This was requested by chrome. I can't really think of a strong
justification for this paternalistic behavior, and I can think of
some against it, mainly that it causes CF to behave unlike the user
expects.

Fixes: b/382207330
@jonathanmetzman
Copy link
Collaborator Author

@oliverchang WDYT about getting rid of this. I didn't want to add more configs to hack around something I consider unnecessary.

Copy link
Collaborator

@vitorguidi vitorguidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman jonathanmetzman merged commit 01239a0 into master Jan 15, 2025
7 checks passed
@jonathanmetzman jonathanmetzman deleted the ad branch January 15, 2025 15:10
adetaylor pushed a commit to adetaylor/clusterfuzz that referenced this pull request Jan 23, 2025
This was requested by chrome. I can't really think of a strong
justification for this paternalistic behavior, and I can think of some
against it, mainly that it causes CF to behave unlike the user expects.

Fixes: b/382207330
letitz pushed a commit that referenced this pull request Jan 23, 2025
This was requested by chrome. I can't really think of a strong
justification for this paternalistic behavior, and I can think of some
against it, mainly that it causes CF to behave unlike the user expects.

Cherry-picked from 01239a0 in master.

Fixes: b/382207330

Co-authored-by: jonathanmetzman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants