Bound preprocess and parallel signing calls #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorguidi
reviewed
Dec 27, 2024
| else: | ||
| yield multiprocessing.Pool(pool_size) | ||
| yield futures.ProcessPoolExecutor(pool_size) |
There was a problem hiding this comment.
Why processes and not threads?
There was a problem hiding this comment.
This is mostly used for CPU bound tasks such as cryptographic signing. In addition, Python's threads suck and processes are usually faster for things like I/O bound stuff.
vitorguidi
reviewed
Dec 27, 2024
| @@ -616,6 +656,9 @@ def run(self): | |||
| if time_left <= 0: | |||
| logs.info('Lease reached maximum lease time of {} seconds, ' | |||
| 'stopping renewal.'.format(self._max_lease_seconds)) | |||
| if self._ack_on_timeout: | |||
| logs.info('Acking on timeout') | |||
| self._message.ack() | |||
There was a problem hiding this comment.
Why acking? Why is this preferred to exiting and retrying later?
There was a problem hiding this comment.
For fuzz tasks, I'd rather things starve for now than gum up the queue.
vitorguidi
reviewed
Dec 27, 2024
| @@ -1377,17 +1378,24 @@ def get_arbitrary_signed_upload_url(remote_directory): | |||
| get_arbitrary_signed_upload_urls(remote_directory, num_uploads=1))[0] | |||
|
|
|||
|
|
|||
| def maybe_parallel_map(func, arguments): | |||
| def parallel_map(func, argument_list): | |||
There was a problem hiding this comment.
The if statement is being removed because the rearch is complete, right?
vitorguidi
added a commit
that referenced
this pull request
Dec 28, 2024
This reverts commit 36505ab.
vitorguidi
added a commit
that referenced
this pull request
Dec 28, 2024
This reverts commit 36505ab.
Merged
vitorguidi
added a commit
that referenced
this pull request
Dec 28, 2024
The preprocess count for fuzz task went to zero after #4564 got deployed, reverting. #4528 is also being reverted because it introduced the following error into the fuzz task scheduler, which caused fuzz tasks to stop being scheduled: ``` Traceback (most recent call last): File "/mnt/scratch0/clusterfuzz/src/python/bot/startup/run_cron.py", line 68, in <module> sys.exit(main()) ^^^^^^ File "/mnt/scratch0/clusterfuzz/src/python/bot/startup/run_cron.py", line 64, in main return 0 if task_module.main() else 1 ^^^^^^^^^^^^^^^^^^ File "/mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/cron/schedule_fuzz.py", line 304, in main return schedule_fuzz_tasks() ^^^^^^^^^^^^^^^^^^^^^ File "/mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/cron/schedule_fuzz.py", line 284, in schedule_fuzz_tasks available_cpus = get_available_cpus(project, regions) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/cron/schedule_fuzz.py", line 247, in get_available_cpus result = pool.starmap_async( # pylint: disable=no-member ^^^^^^^^^^^^^^^^^^ AttributeError: 'ProcessPoolExecutor' object has no attribute 'starmap_async' ```
jonathanmetzman
added a commit
that referenced
this pull request
Jan 8, 2025
Bound preprocess to 30 minutes (shouldn't be more than 5) Bound parallel signing to 2 minutes, exception if we pass this.
jonathanmetzman
pushed a commit
that referenced
this pull request
Jan 8, 2025
The preprocess count for fuzz task went to zero after #4564 got deployed, reverting. #4528 is also being reverted because it introduced the following error into the fuzz task scheduler, which caused fuzz tasks to stop being scheduled: ``` Traceback (most recent call last): File "/mnt/scratch0/clusterfuzz/src/python/bot/startup/run_cron.py", line 68, in <module> sys.exit(main()) ^^^^^^ File "/mnt/scratch0/clusterfuzz/src/python/bot/startup/run_cron.py", line 64, in main return 0 if task_module.main() else 1 ^^^^^^^^^^^^^^^^^^ File "/mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/cron/schedule_fuzz.py", line 304, in main return schedule_fuzz_tasks() ^^^^^^^^^^^^^^^^^^^^^ File "/mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/cron/schedule_fuzz.py", line 284, in schedule_fuzz_tasks available_cpus = get_available_cpus(project, regions) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/cron/schedule_fuzz.py", line 247, in get_available_cpus result = pool.starmap_async( # pylint: disable=no-member ^^^^^^^^^^^^^^^^^^ AttributeError: 'ProcessPoolExecutor' object has no attribute 'starmap_async' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bound preprocess to 30 minutes (shouldn't be more than 5)
Bound parallel signing to 2 minutes, exception if we pass this.