Skip to content

Bug fixes to WebRTC externs #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bug fixes to WebRTC externs #4228

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eb4a21
Correct RTCRtpSender.addTrack, as the stream is optional
hills Mar 17, 2023
837ec19
Correct RTCTrackEvent which inherits from Event
hills Sep 22, 2023
0005e47
Correct RTCEncoded{Audio,Video}Frame whose member is not read-only
hills Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions externs/browser/w3c_rtc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ RTCEncodedVideoFrameMetadata.prototype.width;
function RTCEncodedVideoFrame() {}

/**
* @const {!ArrayBuffer}
* @type {!ArrayBuffer}
*/
RTCEncodedVideoFrame.prototype.data;

Expand Down Expand Up @@ -732,7 +732,7 @@ RTCEncodedAudioFrameMetadata.prototype.synchronizationSource;
function RTCEncodedAudioFrame() {}

/**
* @const {!ArrayBuffer}
* @type {!ArrayBuffer}
*/
RTCEncodedAudioFrame.prototype.data;

Expand Down Expand Up @@ -1836,6 +1836,7 @@ ImageCapture.prototype.track;
* @see https://www.w3.org/TR/webrtc/#rtctrackevent
* @param {string} type
* @param {!Object} eventInitDict
* @extends {Event}
* @constructor
*/
function RTCTrackEvent(type, eventInitDict) {}
Expand Down Expand Up @@ -3688,11 +3689,10 @@ RTCPeerConnection.prototype.removeStream = function(stream) {};

/**
* @param {!MediaStreamTrack} track
* @param {!MediaStream} stream
* @param {...MediaStream} var_args Additional streams.
* @param {...MediaStream} var_args Optional streams.
* @return {!RTCRtpSender}
*/
RTCPeerConnection.prototype.addTrack = function(track, stream, var_args) {};
RTCPeerConnection.prototype.addTrack = function(track, var_args) {};

/**
* @param {!MediaStreamTrack|string} trackOrKind
Expand Down