Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building against system Brotli #1182

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+243 −187
Open

Allow building against system Brotli #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a01fd8
+ Added ability to build Brotli Python bindings against system-provid…
gorloffslava Jul 29, 2024
b93502d
fix: renamed print
BwL1289 Aug 30, 2024
9018ef3
Merge branch 'google:master' into master
gorloffslava Oct 16, 2024
1c380db
Merge branch 'google:master' into master
gorloffslava Oct 31, 2024
3a444a6
Merge branch 'google:master' into master
gorloffslava Nov 21, 2024
0ea9927
+ Improved setup.py formatting
gorloffslava Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build-system]
requires = ["setuptools"]
requires = ["setuptools", "pkgconfig"]
build-backend = "setuptools.build_meta"
10 changes: 10 additions & 0 deletions python/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ following command from this directory:

$ make install

If you already have native Brotli installed on your system and want to use this one instead of the vendored sources, you
should set the `USE_SYSTEM_BROTLI=1` environment variable when building the wheel, like this:

$ USE_SYSTEM_BROTLI=1 pip install brotli --no-binary brotli

Brotli is found via the `pkg-config` utility. Moreover, you must build all 3 `brotlicommon`, `brotlienc`, and `brotlidec`
components. If you're installing brotli from the package manager, you need the development package, like this on Fedora:

$ dnf install brotli brotli-devel

### Development

You may run the following commands from this directory:
Expand Down
Loading