generalize BC file loading #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunagrawal
reviewed
Jul 1, 2025
| # Load the first file that ends with "_config.json". | ||
| # This allows loading a BC inference function from, e.g., a PPO checkpoint. | ||
| config_fname = next(path.glob('*_config.json')) | ||
| config_path = path / config_fname |
There was a problem hiding this comment.
I think a better approach would be to allow the the parameter config_fname with the default _CONFIG_FNAME. This would make the code backwards compatible.
Contributor
Author
There was a problem hiding this comment.
Thanks I see how this could break stuff. Updated.
btaba
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for google-deepmind/mujoco_playground#76
Allows you to run the BC inference function on a PPO policy checkpoint.
The BC inference function provides additional metadata required for behaviour cloning.