dist: Ship siso and cipd CLIs with -help smoke tests#30
Merged
Conversation
Adds the upstream siso and cipd binaries to //dist so the sandbox can run `siso proxy` and `cipd proxy` outside the jail and expose unix sockets inside, letting in-jail Chrome/Android dev tooling reach RBE / fetch CIPD packages without host credentials or network egress. Both binaries are built from source via rules_go from upstream module versions (siso v1.5.3, luci pinned by pseudo-version) so go.sum hash-locks the entire dep closure. Build wiring: - bump go_sdk download 1.24.12 → 1.25.7 (siso v1.5.3 needs go ≥ 1.25.7) - bump go.mod `go` directive accordingly - add tools.go (build tag `tools`) so `go mod tidy` walks the full siso and cipd CLI dep graph, anchoring transitive deps in go.mod - gazelle_default_attributes(build_file_generation=clean, proto disable_global) so gazelle regenerates BUILD files for every external module and skips proto-rule generation; without this the hand-written BUILD files in luci-go / remote-apis / reclient/api reference @rules_go and @rules_proto via names that aren't visible in our bzlmod context - pkg_files in //dist:binaries gains the two new go_binary targets Smoke tests: dist/dist_test.go's helpSmokeTest extracts the dist tarball and runs `<bin> help [-advanced]`, asserting the output mentions `proxy`. Catches packaging regressions (missing/wrong-arch binary, dynamic-link breakage) cheaply, without exercising any network path.
acb29a3 to
d2168db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the upstream siso and cipd binaries to //dist so the sandbox can run
siso proxyandcipd proxyoutside the jail and expose unix sockets inside, letting in-jail Chrome/Android dev tooling reach RBE / fetch CIPD packages without host credentials or network egress.Both binaries are built from source via rules_go from upstream module versions (siso v1.5.3, luci pinned by pseudo-version) so go.sum hash-locks the entire dep closure. Build wiring:
godirective accordinglytools) sogo mod tidywalks the full siso and cipd CLI dep graph, anchoring transitive deps in go.modSmoke tests: dist/dist_test.go's helpSmokeTest extracts the dist tarball and runs
<bin> help [-advanced], asserting the output mentionsproxy. Catches packaging regressions (missing/wrong-arch binary, dynamic-link breakage) cheaply, without exercising any network path.