Skip to content

docs: correct typo in conversion_utils.py #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Quantisan
Copy link

correcting MCP terminology in a docstring to avoid confusion

Copy link

google-cla bot commented Apr 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@hangfei hangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix commit message(see check failures)

@@ -22,7 +22,7 @@ def adk_to_mcp_tool_type(tool: BaseTool) -> mcp_types.Tool:
"""Convert a Tool in ADK into MCP tool type.

This function transforms an ADK tool definition into its equivalent
representation in the MCP (Model Control Plane) system.
representation in the MCP (Model Context Protocol) system.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> MCP (Model Context Protocol) representation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Quantisan please change to this for brevity.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. But Let's keep the original indentation.

@Quantisan
Copy link
Author

updated commit message

@Quantisan Quantisan requested a review from hangfei April 23, 2025 03:54
@Quantisan Quantisan force-pushed the patch-2 branch 2 times, most recently from 7e45607 to 38ce9d1 Compare April 23, 2025 04:22
@Quantisan Quantisan changed the title fix typo in conversion_utils.py docs: correct typo in conversion_utils.py Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants