feat: use async on session service #343
Open
+7,118
−362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: current implementations of `BaseSessionService` should use async now.
fix tests with missing await statement
thiagosalvatore
changed the title
hcadioli
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #347 .
Description
The current implementation of
BaseSessionServiceis not async. It has a ton of I/O operations that would block the main event loop. Instead, we should leverage async to run database operations on the session.This PR updates the BaseSessionService as well as its implementations to use async, preventing the event loop from being blocked and allowing the usage of other database implementations like
motorfor MongoDB.This PR does not updates the
DatabaseSessionServiceto use the async version of sqlalchemy.Tests