Auth credential exchange registry implementation #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariprasath2603
changed the title
hariprasath2603
force-pushed
the
hariprasath2603/auth-credential-excahnger
branch
from
2fdff27 to
a044637
Compare
cornellgit
approved these changes
Nov 24, 2025
| * @throws CredentialExchangeError: If credential exchange fails. | ||
| */ | ||
|
|
||
| exchange( |
Collaborator
There was a problem hiding this comment.
let's use named Parameters
Collaborator
Author
There was a problem hiding this comment.
I changed the exchange method to use named parameters.
| expect(registry.getExchanger(AuthCredentialTypes.API_KEY)).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('should register a single exchanger', () => { |
Collaborator
There was a problem hiding this comment.
nit: test case can be simplified to focus on one type.
Collaborator
Author
There was a problem hiding this comment.
Removed the API_KEY type in the test case to keep the test simple.
- Converted the exchange method parameters in base credential exchanger to named parameters - Removed the API_KEY registry on empty registry test
hariprasath2603
force-pushed
the
hariprasath2603/auth-credential-excahnger
branch
from
c6e9c9e to
5973b44
Compare
cornellgit
added
ready to pull
cornellgit
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation