feat: setup subrouter for pub/sub trigger#704
Open
anFatum wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
anFatum
force-pushed
the
pubsub-subrouter
branch
from
20af916 to
8df5c76
Compare
Collaborator
kdroste-google
left a comment
kdroste-google
left a comment
There was a problem hiding this comment.
Please see my comments
| return | ||
| } | ||
|
|
||
| if _, err := c.runAgent(r.Context(), appName, req.Subscription, messageContent); err != nil { |
Collaborator
There was a problem hiding this comment.
Here messageContent is either req.Message.Data (string with base64 encoded free-format string) or req.Message.Attributes (string with JSON representation of the string-to-string map). Is that correct?
Contributor
Author
There was a problem hiding this comment.
Yes, see the comment above
anFatum
force-pushed
the
pubsub-subrouter
branch
5 times, most recently
from
e4cdcd9 to
b8ac13a
Compare
anFatum
force-pushed
the
pubsub-subrouter
branch
from
b8ac13a to
bba95b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new subrouter that will handle the pubsub trigger endpoint and add the implementation for this trigger.
This implementation should handle the resource exhausted exceptions with jitter to prevent thundering herd (configured per subrouter).
(see the details in go/orcas-rfc-522)