Skip to content

DNS: Temporary workaround for C++ SDK Crash. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

DNS: Temporary workaround for C++ SDK Crash. #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions GoogleUtilities/Logger/GULLogger.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,14 @@ void GULLoggerEnableSTDERR(void) {
}

void GULLoggerForceDebug(void) {
#warning Return instead of doing anything to avoid the App Store check.
return;

// We should enable debug mode if we're not running from App Store.
if (![GULAppEnvironmentUtil isFromAppStore]) {
sGULLoggerDebugMode = YES;
GULSetLoggerLevel(GULLoggerLevelDebug);
}
// if (![GULAppEnvironmentUtil isFromAppStore]) {
// sGULLoggerDebugMode = YES;
// GULSetLoggerLevel(GULLoggerLevelDebug);
// }
}

__attribute__((no_sanitize("thread"))) void GULSetLoggerLevel(GULLoggerLevel loggerLevel) {
Expand All @@ -98,8 +101,10 @@ void GULLoggerForceDebug(void) {
return;
}
GULLoggerInitializeASL();
#warning Ensure nothing below Notice is set to avoid the App Store check.
// We should not raise the logger level if we are running from App Store.
if (loggerLevel >= GULLoggerLevelNotice && [GULAppEnvironmentUtil isFromAppStore]) {
// if (loggerLevel >= GULLoggerLevelNotice && [GULAppEnvironmentUtil isFromAppStore]) {
if (loggerLevel >= GULLoggerLevelNotice) {
return;
}

Expand Down