Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Aug 7, 2023

This is another approach to #119 that I think is probably better.

Some context, the test crashes are originating in tests that test our category on NSURLSession. We use OCMock to stub the behavior of the underlying NSURLSession. Rather than using OCMock, I figured we could use the real NSURLSession, and instead make local requests on file system URLs. This approach seems to actually work well and wasn't difficult to set up.

Fixes CI failures in PRs like #110 and #118

@ncooke3
Copy link
Member Author

ncooke3 commented Aug 7, 2023

Hmm, that's weird, google-utilities / catalyst (pull_request) still failed. It seems the test crashing us unrelated to the test's implementation.

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • GoogleUtilities-ios-unit-GoogleUtilities.framework

    Overall coverage changed from 0.62% (c38ce36) to 0.62% (470964c) by -0.00%.

    FilenameBase (c38ce36)Merge (470964c)Diff
    GULAppEnvironmentUtil.m2.58%3.14%+0.57%
    IsAppEncrypted.m?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FsRb7JYbIu.html

@ncooke3
Copy link
Member Author

ncooke3 commented Aug 7, 2023

Pausing investigation into the crash. Weirdly, the promise timeout in this PR and in #119 is the same. The crash can be more easily produced by running the tests on Catalyst (via CocoaPods) and enabling the address sanitizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants