ScrollView without content, scroll to content edge issue simulation. #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added disable unit test.
tirodkar
reviewed
Sep 20, 2017
| @@ -28,6 +28,10 @@ - (void)setUp { | |||
| [self openTestViewNamed:@"Scroll Views"]; | |||
| } | |||
|
|
|||
| - (void)DISABLED_testFreezingScrollView { | |||
There was a problem hiding this comment.
Why is this test disabled?
There was a problem hiding this comment.
I see. This is replicating an issue for us. Can you link the issue as well / create one if not already there?
There was a problem hiding this comment.
I don't think we should block this PR on that?
Feel free to create and link one to this Adarsh.
khandpur
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to simulate the UIScrollView issue where scroll view gets stuck in infinite loop if you try to scroll to content edge and scrollView's content size is equal to or smaller than scrollView's own size. For more check this conversation.