Skip to content

Change CallId to allow for more data. #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgindin merged 2 commits into from
Mar 6, 2026
+33 −22
Merged

Change CallId to allow for more data. #793

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a693e20
Change CallId to allow for more data.
jgindin Mar 6, 2026
d72b254
Remove the `call` property.
jgindin Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions specification/v0_10/json/common_types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,23 @@
"description": "The unique identifier for a component, used for both definitions and references within the same surface."
},
"CallId": {
"type": "string",
"description": "The unique identifier for a server initiated function call."
"type": "object",
"description": "The unique identifier for a server initiated function call.",
"properties": {
"agentId": {
"type": "string",
"description": "Identifies the agent initiating the function call."
},
"call": {
"type": "string",
"description": "Name of the function call."
},
"callId": {
"type": "string",
"description": "Uniquely identifies this instance of the function call."
}
},
"required": ["callId"]
Comment on lines +12 to +24
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The property name callId within the CallId object is a bit repetitive (CallId.callId). For better clarity and to avoid this stutter, consider renaming callId to id. This would result in a more idiomatic CallId.id.

This change would also require updating the required field here and all test cases to use id instead of callId (e.g., "functionCallId": { "id": "unique-call-id-123" }).

Suggested change
"type": "object",
"description": "The unique identifier for a server initiated function call.",
"properties": {
"agentId": {
"type": "string",
"description": "Identifies the agent initiating the function call."
},
"call": {
"type": "string",
"description": "Name of the function call."
},
"callId": {
"type": "string",
"description": "Uniquely identifies this instance of the function call."
}
},
"required": ["callId"]
"type": "object",
"description": "The unique identifier for a server initiated function call.",
"properties": {
"agentId": {
"type": "string",
"description": "Identifies the agent initiating the function call."
},
"call": {
"type": "string",
"description": "Name of the function call."
},
"id": {
"type": "string",
"description": "Uniquely identifies this instance of the function call."
}
},
"required": ["id"]

},
"AccessibilityAttributes": {
"type": "object",
Expand Down
20 changes: 10 additions & 10 deletions specification/v0_10/test/cases/call_function_message.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"returnType": "void",
"callableFrom": "clientOrRemote"
},
"functionCallId": "unique-call-id-123",
"functionCallId": { "callId": "unique-call-id-123" },
"wantResponse": true
}
},
Expand All @@ -29,7 +29,7 @@
"returnType": "void",
"callableFrom": "remoteOnly"
},
"functionCallId": "unique-call-id-123a",
"functionCallId": { "callId": "unique-call-id-123a" },
"wantResponse": false
}
},
Expand All @@ -46,7 +46,7 @@
"returnType": "void",
"callableFrom": "clientOrRemote"
},
"functionCallId": "unique-call-id-124"
"functionCallId": { "callId": "unique-call-id-124" }
}
},
{
Expand All @@ -67,7 +67,7 @@
"valid": false,
"data": {
"version": "v0.10",
"functionCallId": "unique-call-id-125"
"functionCallId": { "callId": "unique-call-id-125" }
}
},
{
Expand All @@ -81,7 +81,7 @@
"returnType": "boolean",
"callableFrom": "clientOnly"
},
"functionCallId": "unique-call-id-126"
"functionCallId": { "callId": "unique-call-id-126" }
}
},
{
Expand All @@ -94,7 +94,7 @@
"args": { "value": "bar" },
"returnType": "boolean"
},
"functionCallId": "unique-call-id-126b"
"functionCallId": { "callId": "unique-call-id-126b" }
}
},
{
Expand All @@ -110,7 +110,7 @@
"returnType": "boolean",
"callableFrom": "clientOrRemote"
},
"functionCallId": "unique-call-id-127"
"functionCallId": { "callId": "unique-call-id-127" }
}
},
{
Expand All @@ -126,7 +126,7 @@
"returnType": "boolean",
"callableFrom": "clientOrRemote"
},
"functionCallId": "unique-call-id-128"
"functionCallId": { "callId": "unique-call-id-128" }
}
},
{
Expand All @@ -140,7 +140,7 @@
"returnType": "object",
"callableFrom": "clientOrRemote"
},
"functionCallId": "unique-call-id-129"
"functionCallId": { "callId": "unique-call-id-129" }
}
},
{
Expand All @@ -156,7 +156,7 @@
"returnType": "boolean",
"callableFrom": "clientOrRemote"
},
"functionCallId": "id-3"
"functionCallId": { "callId": "id-3" }
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions specification/v0_10/test/cases/client_messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"version": "v0.10",
"error": {
"code": "FUNCTION_FAILED",
"functionCallId": "unique-call-id-132",
"functionCallId": { "callId": "unique-call-id-132" },
"message": "Something went wrong"
}
}
Expand All @@ -62,7 +62,7 @@
"version": "v0.10",
"error": {
"code": "FUNCTION_FAILED",
"functionCallId": "unique-call-id-133",
"functionCallId": { "callId": "unique-call-id-133" },
"surfaceId": "main",
"message": "Something went wrong"
}
Expand Down
16 changes: 8 additions & 8 deletions specification/v0_10/test/cases/function_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": "unique-call-id-130",
"functionCallId": { "callId": "unique-call-id-130" },
"value": {
"result": "success",
"count": 42
Expand All @@ -33,7 +33,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": "unique-call-id-131a",
"functionCallId": { "callId": "unique-call-id-131a" },
"value": "success"
}
}
Expand All @@ -44,7 +44,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": "unique-call-id-131b",
"functionCallId": { "callId": "unique-call-id-131b" },
"value": 42
}
}
Expand All @@ -55,7 +55,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": "unique-call-id-131c",
"functionCallId": { "callId": "unique-call-id-131c" },
"value": true
}
}
Expand All @@ -66,7 +66,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": "unique-call-id-131d",
"functionCallId": { "callId": "unique-call-id-131d" },
"value": null
}
}
Expand All @@ -77,7 +77,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": "unique-call-id-131e",
"functionCallId": { "callId": "unique-call-id-131e" },
"value": [
"one",
2,
Expand All @@ -93,7 +93,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": "unique-call-id-131",
"functionCallId": { "callId": "unique-call-id-131" },
"value": {
"result": { "nested": "object" }
}
Expand All @@ -106,7 +106,7 @@
"data": {
"version": "v0.10",
"functionResponse": {
"functionCallId": "unique-call-id-131f",
"functionCallId": { "callId": "unique-call-id-131f" },
"value": [
"one",
{
Expand Down
Loading