Conversation
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the MarkdownRenderer to be asynchronous, returning a Promise<string>. The changes are correctly propagated throughout the Angular and Lit renderers, using appropriate mechanisms like Angular's AsyncPipe and Lit's until directive to handle the promises. The type definitions and tests have also been updated to reflect this change. My review includes a couple of minor suggestions to simplify the implementation of some of the new async functions for better code clarity and adherence to best practices.
ac021a8 to
3ad36bc
Compare
|
I had to uncommit the changes to package-lock.json coming from my dev box so CI could continue. Also addressed PR feedback and applied formatting to the markdown-it package. I'm landing this! |
| "name": "@a2ui/web_core", | ||
| "version": "0.8.2", | ||
| "version": "0.8.3", | ||
| "description": "A2UI Core Library", |
Description
Makes
MarkdownRendererreturn aPromise<string>to allow for async markdown rendering.Also updates the Angular and Lit renderers to support the new async rendering.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.