Skip to content

Make MarkdownRenderer async.#787

Merged
ditman merged 6 commits intogoogle:mainfrom
ditman:async-markdown-renderer
Mar 6, 2026
Merged

Make MarkdownRenderer async.#787
ditman merged 6 commits intogoogle:mainfrom
ditman:async-markdown-renderer

Conversation

@ditman
Copy link
Collaborator

@ditman ditman commented Mar 6, 2026

Description

Makes MarkdownRenderer return a Promise<string> to allow for async markdown rendering.

Also updates the Angular and Lit renderers to support the new async rendering.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully refactors the MarkdownRenderer to be asynchronous, returning a Promise<string>. The changes are correctly propagated throughout the Angular and Lit renderers, using appropriate mechanisms like Angular's AsyncPipe and Lit's until directive to handle the promises. The type definitions and tests have also been updated to reflect this change. My review includes a couple of minor suggestions to simplify the implementation of some of the new async functions for better code clarity and adherence to best practices.

@ditman ditman force-pushed the async-markdown-renderer branch from ac021a8 to 3ad36bc Compare March 6, 2026 02:50
@ditman
Copy link
Collaborator Author

ditman commented Mar 6, 2026

I had to uncommit the changes to package-lock.json coming from my dev box so CI could continue. Also addressed PR feedback and applied formatting to the markdown-it package. I'm landing this!

@ditman ditman merged commit b904548 into google:main Mar 6, 2026
8 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in A2UI Mar 6, 2026
"name": "@a2ui/web_core",
"version": "0.8.2",
"version": "0.8.3",
"description": "A2UI Core Library",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

@ditman ditman mentioned this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants