fix(web_core): schema parity and client event context resolution#783
Merged
gspencergoog merged 4 commits intogoogle:mainfrom Mar 5, 2026
Merged
fix(web_core): schema parity and client event context resolution#783gspencergoog merged 4 commits intogoogle:mainfrom
gspencergoog merged 4 commits intogoogle:mainfrom
Conversation
Collaborator
gspencergoog
commented
Mar 5, 2026
gspencergoog
commented
- Resolves inconsistencies between Zod schema definitions and TypeScript types for v0.8 API model updates.
- Refines data path resolution in the Lit shell for resolving context bound values in component actions.
- Resolves inconsistencies between Zod schema definitions and TypeScript types for v0.8 API model updates. - Refines data path resolution in the Lit shell for resolving context bound values in component actions.
gspencergoog
requested review from
ava-cassiopeia,
crisbeto,
ditman,
jacobsimionato and
paullewis
as code owners
gspencergoog
requested review from
dmandar,
nan-yu,
yjbanov and
zeroasterisk
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request focuses on achieving parity between Zod schemas and TypeScript types for the v0.8 API, and improving data path resolution. A significant security vulnerability has been identified: the introduction of recursive data structures in ValueMapSchema without a depth limit poses a potential Denial of Service (DoS) risk due to unbounded recursion. Furthermore, the review highlighted a leftover .only in a test file and an opportunity to refactor demo scripts in package.json for better efficiency.
ditman
approved these changes
Mar 5, 2026
Collaborator
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
There's a couple of comments from Gemini that might make sense, but if not, ship it! Thanks for the quick fix!
gspencergoog
removed request for
ava-cassiopeia,
crisbeto,
dmandar,
jacobsimionato,
nan-yu,
paullewis,
yjbanov and
zeroasterisk
gspencergoog
force-pushed
the
fix_lit_examples
branch
from
c43cf7c to
24416d0
Compare
Collaborator
Author
|
Addressed the gemini review feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.