Delete the generated spec assets in the agent SDK#773
Merged
gspencergoog merged 2 commits intogoogle:mainfrom Mar 4, 2026
Merged
Delete the generated spec assets in the agent SDK#773gspencergoog merged 2 commits intogoogle:mainfrom
gspencergoog merged 2 commits intogoogle:mainfrom
Conversation
nan-yu
requested review from
ditman,
dmandar,
gspencergoog,
jacobsimionato,
yjbanov and
zeroasterisk
as code owners
google#760 accidentally checked in obsolete and generated assets. This commit removes them and also updates the git ignore file to ignore them when checking in code.
nan-yu
force-pushed
the
remove-schema-copy
branch
from
4537e5c to
a47426c
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where generated and obsolete assets were accidentally checked into the repository. The changes involve removing these JSON asset files from the a2a_agents directory and updating the root .gitignore file to prevent them from being checked in again. The local .gitignore from the Python agent SDK is also removed as its rule has been centralized. My review suggests a small improvement to the new .gitignore rules to make them more generic and future-proof.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
gspencergoog
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#760 accidentally checked in obsolete and generated assets.
This commit removes them and also updates the git ignore file to ignore them when checking in code.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.