refactor: Move mcp directory out of adk and place it in `samples/…#760
Merged
sugoi-yuzuru merged 1 commit intomainfrom Mar 3, 2026
Merged
refactor: Move mcp directory out of adk and place it in `samples/…#760sugoi-yuzuru merged 1 commit intomainfrom
mcp directory out of adk and place it in `samples/…#760sugoi-yuzuru merged 1 commit intomainfrom
Conversation
sugoi-yuzuru
requested review from
ditman,
dmandar,
gspencergoog,
jacobsimionato and
nan-yu
as code owners
gspencergoog
approved these changes
Mar 3, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the project structure by moving the mcp directory from samples/agent/adk/ to samples/agent/. While the uv.lock dependency updates are correct, the moved server.py file introduces security risks due to a permissive CORS policy and enabled debug mode, which are unsuitable for production environments. Furthermore, the refactoring is incomplete, leading to critical pathing issues as several files, including samples/agent/mcp/server.py and samples/agent/mcp/pyproject.toml, contain broken relative paths that must be updated to prevent runtime errors.
…agent` as a sibling. The intent is that `mcp` will house further MCP-related examples, and by separating it out from the `adk` directory, we want to refine the `adk` directory to be where the Agents are defined. Since MCP is still a Agent-specific resource, we will place it within the `samples/agent` directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…agent` as a sibling.
Description
The intent is that
mcpwill house further MCP-related examples, and by separating it out from theadkdirectory, we want to refine theadkdirectory to be where the Agents are defined. Since MCP is still a Agent-specific resource, we will place it within thesamples/agentdirectory.Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.