feat: add missing-typography lint rule#6
Merged
Conversation
xkxx
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new lint rule
missing-typographyto thedesign.mdlinter.Rationale
The current
missing-sectionsrule checks for missingspacingandroundedsections when colors are present, but it does not check fortypography. Typography is a core part of a design system; without explicit typography tokens, consumers are forced to fall back to default fonts, reducing the author's control over the design system's identity.Changes
missing-typographyrule inpackages/cli/src/linter/linter/rules/missing-typography.ts.packages/cli/src/linter/linter/rules/missing-typography.test.ts.README.mdto document the new rule.types.test.tsandspec.test.tsto account for the new rule count (8 instead of 7).Verification
Ran
bun testand all 185 tests passed successfully.