Skip to content

feat: add missing-typography lint rule#6

Merged
davideast merged 1 commit into
mainfrom
add-missing-typography-rule
Apr 14, 2026
Merged

feat: add missing-typography lint rule#6
davideast merged 1 commit into
mainfrom
add-missing-typography-rule

Conversation

@chelseayerong

Copy link
Copy Markdown
Contributor

Description

This PR adds a new lint rule missing-typography to the design.md linter.

Rationale

The current missing-sections rule checks for missing spacing and rounded sections when colors are present, but it does not check for typography. Typography is a core part of a design system; without explicit typography tokens, consumers are forced to fall back to default fonts, reducing the author's control over the design system's identity.

Changes

  • Added missing-typography rule in packages/cli/src/linter/linter/rules/missing-typography.ts.
  • Added unit tests in packages/cli/src/linter/linter/rules/missing-typography.test.ts.
  • Registered the new rule in the default rules list.
  • Updated README.md to document the new rule.
  • Updated existing tests in types.test.ts and spec.test.ts to account for the new rule count (8 instead of 7).

Verification

Ran bun test and all 185 tests passed successfully.

@chelseayerong
chelseayerong requested a review from xkxx April 13, 2026 22:38
@xkxx
xkxx requested a review from davideast April 13, 2026 22:44

@davideast davideast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@davideast
davideast merged commit b7aeacf into main Apr 14, 2026
6 checks passed
@davideast
davideast deleted the add-missing-typography-rule branch April 14, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants