Skip to content

fix: render primitive types from spec config#131

Open
juliosuas wants to merge 2 commits into
google-labs-code:mainfrom
juliosuas:fix/spec-config-types
Open

fix: render primitive types from spec config#131
juliosuas wants to merge 2 commits into
google-labs-code:mainfrom
juliosuas:fix/spec-config-types

Conversation

@juliosuas

Copy link
Copy Markdown

Fixes #97. Moves primitive type definitions into spec-config.yaml and renders them through the spec generator, so Color and Dimension are driven by the same config source as sections, units, typography properties, and component sub-tokens. Validation: focused spec-config/spec-gen tests passed; generate --check passed; full bun run test, bun run lint, bun run build, and git diff --check passed.

@google-cla

google-cla Bot commented Jun 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rajpratham1 rajpratham1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a well-structured refactor that moves primitive type definitions into the shared spec configuration instead of duplicating them inside the generated documentation. It improves maintainability, keeps the specification as a single source of truth, and includes appropriate validation and regression tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color type definition is not driven by spec-config.yaml

2 participants