Skip to content

feat: mdformat to match internal style - #56

Open
markmcd wants to merge 4 commits into
mainfrom
mdformat
Open

feat: mdformat to match internal style#56
markmcd wants to merge 4 commits into
mainfrom
mdformat

Conversation

@markmcd

@markmcd markmcd commented Jun 23, 2026

Copy link
Copy Markdown
Member

Internally skills need to be formatted with mdformat, and since this project is set up as GH SoT, it needs to be implemented here.

Also reformatted all markdown in the repo.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a markdown formatting tool consisting of a Python script (scripts/format.py) and a helper bash script (scripts/format.sh) to automate formatting using mdformat. It also updates .gitignore to exclude the virtual environment directory and applies the formatter to several documentation files, wrapping text to 80 characters and standardizing formatting. The review feedback identifies an opportunity to optimize scripts/format.sh by checking for the existence of executables inside the virtual environment and avoiding redundant pip install calls on every execution, which improves both robustness and performance.

Comment thread scripts/format.sh Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

@philschmid philschmid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should noy change the external format. Each linebreaks adds at least 1 token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants