feat: keyboard navigation in app header dropdowns #5980
+588
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-nejezchleb
force-pushed
the
ine-lx-727
branch
7 times, most recently
from
83424f6 to
567e90e
Compare
- new FocusTrap component - provide aria attributes to the buttons opening dropdowns/menus - handle keyboard navigation back from dropdown JIRA: LX-727 risk: low
* Make return back from trap to main context simple * Let keyboard trigger menu items actions * Add keyboard navigation to Tabs comp. JIRA: LX-727 risk: low
JIRA: LX-727 risk: low
JIRA: LX-727 risk: low
ivan-nejezchleb
force-pushed
the
ine-lx-727
branch
from
567e90e to
e2c8f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: LX-727
risk: low
Important
Please, don't forget to run
rush changefor the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.Run extended test by pull request comment
Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.
Explanation
--backstopThe command to run screen tests.--integratedThe command to run integrated tests against the live backend.--isolatedThe command to run isolated tests against recordings.--recordThe command to create new recordings for isolated tests.--filter(Optional) A comma-separated list of test files to run. This parameter is valid only for the--integrated,--isolated, and--recordcommands.Examples