feat: enhance telemetry capabilities #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerstanislav
previously approved these changes
Feb 26, 2025
kandl
force-pushed
the
mkn-stl-1062
branch
4 times, most recently
from
6bf8f3d to
889b816
Compare
pbenes
reviewed
Feb 27, 2025
| }; | ||
| } | ||
|
|
||
| const effectiveBackend = useBackendWithCorrelation(backend, correlationData); |
There was a problem hiding this comment.
Just curious why we are calling useBackendWithCorrelation twice with the same correlationData?
I mean why just not
return useBackendWithCorrelation(backend, correlationData);
Add `withCorrelation` method to sdk-backend-spi that enables attaching custom metadata to backend requests. In the sdk-backend-tiger implementation, it's provided as an `x-gdc-correlation` header, with stringified correlation metadata as its value. This enhancement enables more detailed telemetry tracking, allowing inclusion of contextual information in requests such as visualization IDs, dashboard IDs, and more. Introduce a new `CorrelationContext` React context that provides a convenient way to set and retrieve backend correlation metadata. Integrate with Dashboard - enhance all requests with dashboardId, and further enrich visualization-related requests with widgetId and visualizationId. Integrate with InsightView - enhance all requests with visualizationId. Also integrate with BaseVisualization. risk: low JIRA: STL-1062
pbenes
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
withCorrelationmethod to sdk-backend-spi that enables attaching custom metadata to backend requests.In the sdk-backend-tiger implementation,
it's provided as an
x-gdc-correlationheader,with stringified correlation metadata as its value.
This enhancement enables more detailed telemetry tracking, allowing inclusion of contextual information in requests such as visualization IDs, dashboard IDs, and more.
Introduce a new
CorrelationContextReact context that provides a convenient way to set and retrievebackend correlation metadata.
Integrate with Dashboard - enhance all requests with dashboardId, and further enrich visualization-related requests with widgetId and visualizationId.
risk: low
JIRA: STL-1062
Important
Please, don't forget to run
rush changefor the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.Run extended test by pull request comment
Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.
Explanation
--backstopThe command to run screen tests.--integratedThe command to run integrated tests against the live backend.--isolatedThe command to run isolated tests against recordings.--recordThe command to create new recordings for isolated tests.--filter(Optional) A comma-separated list of test files to run. This parameter is valid only for the--integrated,--isolated, and--recordcommands.Examples