Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper selector function #5973

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: use proper selector function #5973

merged 1 commit into from
Feb 26, 2025

Conversation

kandl
Copy link
Contributor

@kandl kandl commented Feb 26, 2025

Replace wrong useSelector with correct useDashboardSelector.

risk: low
JIRA: F1-1118


Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.


Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests.
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

Replace wrong `useSelector` with correct `useDashboardSelector`.

risk: low
JIRA: F1-1118
@kandl kandl added the ready to review PR is ready to final code review label Feb 26, 2025
@hackerstanislav hackerstanislav merged commit b5e3076 into master Feb 26, 2025
15 checks passed
@hackerstanislav hackerstanislav deleted the mkn-f1-1118 branch February 26, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review PR is ready to final code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants