Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer native workspace setting over parent one in settings SPI #5969

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

xMort
Copy link
Contributor

@xMort xMort commented Feb 24, 2025

When ID of parent workspace setting property (property set on parent) is located after native workspace setting (property set on child) in the list of properties returned by API response, the SPI backend setting service used parent value instead of the native one. The introduced change fixes the faulty behavior.

JIRA: LX-819
risk: low


Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.


Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests.
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

When ID of parent workspace setting property (property set on parent)
is located after native workspace setting (property set on child) in
the list of properties returned by API response, the SPI backend
setting service used parent value instead of the native one.
The introduced change fixes the faulty behavior.

JIRA: LX-819
risk: low
@xMort xMort requested a review from kandl as a code owner February 24, 2025 13:04
@xMort xMort enabled auto-merge February 24, 2025 13:14
@xMort xMort merged commit a7a5177 into master Feb 24, 2025
15 checks passed
@xMort xMort deleted the pdo-lx-819-child-settings branch February 24, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants