Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cancel executions in PivotTable/Repeater #5968

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

kandl
Copy link
Contributor

@kandl kandl commented Feb 24, 2025

Add support for execution cancellation in PivotTable and Repeater.

risk: low
JIRA: F1-1109


Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.


Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests.
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

@kandl kandl added the ready to review PR is ready to final code review label Feb 24, 2025
@ivanmjartan
Copy link
Contributor

extended-test --backstop

@ivanmjartan
Copy link
Contributor

extended-test --isolated

@ivanmjartan
Copy link
Contributor

extended-test --integrated

Copy link

"extended-test --backstop" started. Check the progress here.

Copy link

"extended-test --isolated" started. Check the progress here.

Copy link

"extended-test --integrated" started. Check the progress here.

Copy link

❌ "extended-test --backstop" finished with result failure. Check the results here.

Copy link

❌ "extended-test --integrated" finished with result failure. Check the results here.

Copy link

❌ "extended-test --isolated" finished with result failure. Check the results here.

@kandl
Copy link
Contributor Author

kandl commented Feb 24, 2025

extended-test --isolated

@kandl
Copy link
Contributor Author

kandl commented Feb 24, 2025

extended-test --integrated

Copy link

"extended-test --isolated" started. Check the progress here.

Copy link

"extended-test --integrated" started. Check the progress here.

ivanmjartan
ivanmjartan previously approved these changes Feb 24, 2025
Copy link

✅ "extended-test --integrated" finished with result success. Check the results here.

Copy link

✅ "extended-test --isolated" finished with result success. Check the results here.

@kandl kandl force-pushed the mkn-f1-1109 branch 3 times, most recently from bad79fa to 1d810a1 Compare February 24, 2025 14:52
Add support for execution cancellation in PivotTable and Repeater.

risk: low
JIRA: F1-1109
@hackerstanislav hackerstanislav merged commit 74d299a into master Feb 24, 2025
15 checks passed
@hackerstanislav hackerstanislav deleted the mkn-f1-1109 branch February 24, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review PR is ready to final code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants