Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch the TimeoutException #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+609 −477
Open

catch the TimeoutException #9

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
28d75b4
[U] deleteNodeAndNotifySubscribersTest()
yannickchoni Nov 7, 2019
1d3a8f4
[U] assert if stanza doesnt contain something
yannickchoni Nov 7, 2019
4cb5efd
[U] add a regex to verify if the stanza contains "event" and "delete"…
yannickchoni Nov 8, 2019
11aebc4
[U] add a regex to verify if the stanza contains "event" and "delete"…
yannickchoni Nov 8, 2019
ffea943
Merge branch 'geenie' of https://github.com/yannickchoni/smack-sint-e…
yannickchoni Nov 8, 2019
81d1954
[U] add a regex to verify if the stanza contains "event" and "delete"…
yannickchoni Nov 11, 2019
8bf28fb
catch TimeoutException
yannickchoni Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jivesoftware/smackx/pubsub/PubSubIntegrationTest.java
View file
Original file line number Diff line number Diff line change
@@ -1064,7 +1064,7 @@ public void deleteNodeAndNotifySubscribersTest() throws NoResponseException, XMP
final String needle = "<event xmlns='http://jabber.org/protocol/pubsub#event'>";
final String delete_confirm = "<delete node='princely_musings'>";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work. You're creating a node wit a name that starts with sinttest-delete-node-that-exists-, but you're deleting a node that is named princely_musings.

final String regex = "#^." + needle + "." + delete_confirm + ".$#";
try{
try {
pubSubManagerOne.createNode(nodename);
final Node subscriberNode = pubSubManagerTwo.getNode(nodename);
final EntityBareJid subscriber = conTwo.getUser().asEntityBareJid();