docs: gocritic enabled-checks and disabled-checks can be combined #6090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey, thank you for opening your first Pull Request ! |
ldez
changed the title
The documentation currently indicates that enable-checks and disabled-checks can't be combined for gocritic. That is however not accurate: as per InferEnabledChecks in the gocritic wrapper, * if enable-all is set, all available checks are added to the set of enabled checks * otherwise, unless disable-all is set, the default checks are added to the set of enabled checks * then the checks corresponding to each enabled tag are added * then all enabled checks are added (with a warning if a check is enabled multiple times) * then the checks corresponding to each disabled tag are removed * finally, all disabled checks are removed (with a warning if a check wasn't enabled) Using both enabled-checks and disabled-checks is useful when keeping the default set of checks as reference. This adjusts the documentation to match the implementation. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
gocritic-combinations
branch
from
28dd63d to
0d6e043
Compare
|
Hello @skitt, could you sign the CLA? |
Sorry, I missed that part of the contribution workflow — I’ll have to get approval from our legal department. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation currently indicates that enable-checks and disabled-checks can't be combined for gocritic. That is however not accurate: as per InferEnabledChecks in the gocritic wrapper,
Using both enabled-checks and disabled-checks is useful when keeping the default set of checks as reference.
This adjusts the documentation to match the implementation.
related to #4458