feat: format fixed files with the same formatters as the issues related to formatting #5267
+108
−139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently (since the PR about formatters) the reports related to formatting are handled by a dedicated processor, but the suggested fixes can produce formatting issues.
Inside the fixer, golangci-lint always calls the std formatter but it's better if it calls the formatters from the configuration too.
This PR also improves performance by formatting the files only one time, and by using
fileCache
instead ofos.ReadFile
to get the file content.Note: the formatter processor is merged with the fixer.
This improves cases that can produce missing imports.
Example
The command:
Before this PR, the result is:
with this PR:
because
goimports
fixes imports.Related to #5232, #5246