runtime,runtime/pprof: clean up goroutine leak profile writing #76045

VladSaiocUber · 2025-10-24T15:01:12Z

Cleaned up goroutine leak profile extraction:

removed the acquisition of goroutineProfile semaphore
inlined the call to saveg when recording stacks instead of using
doRecordGoroutineProfile, which had side-effects over
goroutineProfile fields.

Added regression tests for goroutine leak profiling frontend for binary
and debug=1 profile formats.
Added stress tests for concurrent goroutine and goroutine leak profile requests.

gopherbot · 2025-10-24T15:14:19Z

This PR (HEAD: 7f1c287) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-24T15:24:05Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-27T10:02:18Z

This PR (HEAD: 9f938be) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-27T10:28:05Z

Message from Georgian-Vlad Saioc:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-27T10:28:05Z

Message from Georgian-Vlad Saioc:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-27T11:37:47Z

Message from t hepudds:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-27T11:37:47Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-27T11:25:05Z","revision":"b56ebcfe8ea10abbbd4dc11673785d168bf8f191"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-27T11:46:25Z

Message from t hepudds:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-27T11:46:26Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-386 has failed with summary (view all results):

go on master (change 714580)

To reproduce, try gomote repro 8699859655765379761.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-27T11:46:26Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-27T11:46:36Z

This PR (HEAD: 8ddb8be) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-29T17:40:45Z

Message from Michael Knyszek:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T10:21:53Z

This PR (HEAD: 21bfbb3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-30T10:30:20Z

Message from Georgian-Vlad Saioc:

Patch Set 5:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T11:53:56Z

Message from t hepudds:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T12:02:56Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-30T11:44:40Z","revision":"041a4f97b6f23e9cc6c9f9a14a5a5d719016efea"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T12:11:24Z

Message from t hepudds:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T12:11:24Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T12:11:25Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T16:34:21Z

Message from Michael Knyszek:

Patch Set 5: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T16:52:18Z

This PR (HEAD: ddfb0aa) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-30T17:01:19Z

Message from Georgian-Vlad Saioc:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-30T17:54:24Z

Message from Florian Lehner:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-31T16:13:53Z

Message from Michael Knyszek:

Patch Set 6: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-04T13:55:14Z

Message from t hepudds:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-04T13:55:15Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-04T13:39:08Z","revision":"887162a27d8caa8ae89f653b6aed2abe5eec3b84"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-04T14:14:05Z

Message from t hepudds:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T12:32:17Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T12:32:18Z

Message from t hepudds:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T14:25:09Z

Message from Georgian-Vlad Saioc:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T16:34:48Z

Message from Michael Knyszek:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T16:34:48Z

Message from Michael Knyszek:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T16:34:49Z

Message from Michael Knyszek:

Patch Set 7: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T17:19:40Z

This PR (HEAD: 7130fe4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-05T17:46:22Z

Message from Michael Knyszek:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T17:54:41Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-05T17:38:27Z","revision":"619ffbd8644b8cfd10c643c9467b37893359b99c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T17:54:42Z

Message from Michael Knyszek:

Patch Set 8: Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T18:03:04Z

Message from Michael Knyszek:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T18:03:04Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T18:03:05Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-05T20:36:07Z

Message from Michael Pratt:

Patch Set 8: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-06T09:53:33Z

This PR (HEAD: 5e9eb3b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/714580.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-06T10:28:25Z

Message from Georgian-Vlad Saioc:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-06T11:22:35Z

Message from t hepudds:

Patch Set 9: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-06T11:22:35Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-06T11:06:59Z","revision":"830c0028ca17e75d37c090434492a748d1716a80"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-06T11:31:35Z

Message from t hepudds:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-06T11:31:35Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-06T11:31:36Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-06T16:06:21Z

Message from Michael Pratt:

Patch Set 9: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-10T17:58:41Z

Message from Junyang Shao:

Patch Set 9: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

Cleaned up goroutine leak profile extraction: - removed the acquisition of goroutineProfile semaphore - inlined the call to saveg when recording stacks instead of using doRecordGoroutineProfile, which had side-effects over goroutineProfile fields. Added regression tests for goroutine leak profiling frontend for binary and debug=1 profile formats. Added stress tests for concurrent goroutine and goroutine leak profile requests. Change-Id: I55c1bcef11e9a7fb7699b4c5a2353e594d3e7173 GitHub-Last-Rev: 5e9eb3b GitHub-Pull-Request: #76045 Reviewed-on: https://go-review.googlesource.com/c/go/+/714580 Reviewed-by: Michael Pratt <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Junyang Shao <[email protected]>

gopherbot · 2025-11-12T16:14:37Z

Message from Michael Knyszek:

Patch Set 9: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/714580.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-12T16:23:41Z

This PR is being closed because golang.org/cl/714580 has been merged.

austinderek mentioned this pull request Oct 24, 2025

runtime,runtime/pprof: clean up goroutine leak profile collection PullRequestInc/go#121

Closed

VladSaiocUber changed the title ~~runtime,runtime/pprof: clean up goroutine leak profile collection~~ runtime,runtime/pprof: clean up goroutine leak profile writing Oct 24, 2025

VladSaiocUber force-pushed the dev.fix-goroutineleak-profile branch from 7f1c287 to 9f938be Compare October 27, 2025 09:54

Removed useless comment.

7130fe4

austinderek mentioned this pull request Nov 5, 2025

runtime,runtime/pprof: clean up goroutine leak profile writing PullRequestInc/go#152

Closed

Re-added trace example comment on goroutine leak profile lock.

5e9eb3b

gopherbot closed this Nov 12, 2025

runtime,runtime/pprof: clean up goroutine leak profile writing #76045

runtime,runtime/pprof: clean up goroutine leak profile writing #76045

Uh oh!

Conversation

VladSaiocUber commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Oct 24, 2025

Uh oh!

gopherbot commented Oct 24, 2025

Uh oh!

gopherbot commented Oct 27, 2025

Uh oh!

gopherbot commented Oct 27, 2025

Uh oh!

gopherbot commented Oct 27, 2025

Uh oh!

gopherbot commented Oct 27, 2025

Uh oh!

gopherbot commented Oct 27, 2025

Uh oh!

gopherbot commented Oct 27, 2025

Uh oh!

gopherbot commented Oct 27, 2025

Uh oh!

gopherbot commented Oct 27, 2025

Uh oh!

gopherbot commented Oct 27, 2025

Uh oh!

gopherbot commented Oct 29, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 30, 2025

Uh oh!

gopherbot commented Oct 31, 2025

Uh oh!

gopherbot commented Nov 4, 2025

Uh oh!

gopherbot commented Nov 4, 2025

Uh oh!

gopherbot commented Nov 4, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

Uh oh!

gopherbot commented Nov 5, 2025

VladSaiocUber commented Oct 24, 2025 •

edited

Loading