Skip to content

Commit 53a17d8

Browse files
committed
internal/task: remove TODO comment in ConvertPKGToTGZ
The default normalization that adjustTar applies is sufficient for the needs of ConvertPKGToTGZ. There are no additional adjustments needed since they've already been applied in earlier stages. This was expected, and a test run hasn't uncovered anything more to change here, so remove the resolved TODO comment. For golang/go#53632. Change-Id: I024bf5fd739ab07200b7f2339f68cfe340a594c3 Reviewed-on: https://go-review.googlesource.com/c/build/+/447959 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
1 parent c8c8e67 commit 53a17d8

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

internal/task/buildrelease.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -429,9 +429,7 @@ func (b *BuildletStep) ConvertPKGToTGZ(ctx *workflow.TaskContext, in io.Reader,
429429
reader := tar.NewReader(gzReader)
430430
gzWriter := gzip.NewWriter(out)
431431
writer := tar.NewWriter(gzWriter)
432-
if err := adjustTar(reader, writer, "go/", []adjustFunc{
433-
// TODO(go.dev/issue/53632): Use the data from a test run to confirm which adjustments (if any) are needed.
434-
}); err != nil {
432+
if err := adjustTar(reader, writer, "go/", nil); err != nil {
435433
return err
436434
}
437435
if err := writer.Close(); err != nil {

0 commit comments

Comments
 (0)