Skip to content

Commit c8c8e67

Browse files
dmitshurgopherbot
authored andcommitted
internal/relui: switch to new signing path
Also update test data to match, since the fake signing service now applies a signature. Check that it's a signature of the right type. For golang/go#53632. Change-Id: Iea2321e0e0c41ce12e2a6152a2300f03e592c546 Reviewed-on: https://go-review.googlesource.com/c/build/+/447299 Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 78325fe commit c8c8e67

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

internal/relui/buildrelease_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ func testRelease(t *testing.T, wantVersion string, kind task.ReleaseKind) {
302302
OS: "windows",
303303
Arch: "amd64",
304304
Kind: "installer",
305-
}, "I'm an MSI!\n")
305+
}, "I'm an MSI!\n-signed <Windows>")
306306
checkTGZ(t, dlURL, files, "linux-amd64.tar.gz", &task.WebsiteFile{
307307
OS: "linux",
308308
Arch: "amd64",
@@ -332,7 +332,7 @@ func testRelease(t *testing.T, wantVersion string, kind task.ReleaseKind) {
332332
OS: "darwin",
333333
Arch: "amd64",
334334
Kind: "installer",
335-
}, "I'm a .pkg!\n")
335+
}, "I'm a PKG!\n-signed <macOS>")
336336

337337
head, err := deps.gerrit.ReadBranchHead(deps.ctx, "dl", "master")
338338
if err != nil {

internal/relui/workflows.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -365,8 +365,8 @@ func addCommTasks(
365365
wf.Output(wd, "Tweet URL", tweetURL)
366366
}
367367

368-
// TODO(go.dev/issue/53632): Flip to true and later on delete.
369-
const useSignService = false
368+
// TODO(go.dev/issue/53632): Later on: delete the const and all the unused code. 🎉
369+
const useSignService = true
370370

371371
func addSingleReleaseWorkflow(
372372
build *BuildReleaseTasks, milestone *task.MilestoneTasks, version *task.VersionTasks,

0 commit comments

Comments
 (0)