tpl/tplimpl: Prevent overloading of embedded comment shortcode #13277
+120
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmooring
force-pushed
the
comment-warning
branch
from
88dd3ff to
b865f28
Compare
jmooring
changed the title
jmooring
force-pushed
the
comment-warning
branch
2 times, most recently
from
7f2172b to
58e9a1d
Compare
Creates a mechanism to prevent loading of user space templates that match a list of reserved paths. The primary intent is to prevent users from overloading specific embedded templates. For example, with the string "shortcodes/comment" in the list of reserved paths, we do not load any of the following from user space: - layouts/shortcodes/comment.html - layouts/shortcodes/comment.html.html - layouts/shortcodes/comment.en.html.html - layouts/shortcodes/comment.json" - layouts/shortcodes/comment.json.json" - layouts/shortcodes/comment.en.json.json"
jmooring
force-pushed
the
comment-warning
branch
from
58e9a1d to
38b8766
Compare
|
I have thought about this a little, and I understand the problem we're trying to solve, but I suspect a simpler way to go about this is to introduce a reserved namespace (e.g. We should think a little about what the namespace should look like, though. |
|
Closing in favor of #13278. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a mechanism to prevent loading of user space templates that
match a list of reserved paths. The primary intent is to prevent users
from overloading specific embedded templates. For example, with the
string "shortcodes/comment" in the list of reserved paths, we do not
load any of the following from user space: