-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add URI to resource load error #12271
Conversation
cf5d0c1
to
701f555
Compare
The CI failure looked unrelated (timeout during CI environment setup). I force-pushed to retrigger the CI, but it requires approval again. |
701f555
to
8f78d71
Compare
This CI failure looked very related. There seems to be a test that includes the output of a resource load error. Updated that test to match the changes. error for future refference
|
Previouly, only "ERROR failed to fetch remote resource: Forbidden" would be shown when a resource failed to load. In my case, a tweet's author I was embedding using the twitter shortcode switched his profile to private which resulted in my blog failing to build. To figure out where the originates, I added the log to the error message.
8f78d71
to
1d48125
Compare
Rebased on master and addressed conflicts. Would be nice to get this merged. If there's no interest in this PR, feel free to close it. |
Previously, only
ERROR failed to fetch remote resource: Forbidden
would be shown when a resource failed to load. In my case, a tweet's author I was embedding using the twitter shortcode switched his profile to private which resulted in my blog failing to build. To figure out where the failure originates, I added the log to the error message. This should be useful for others too.