Skip to content

Set install location to auto for better storage management - #25

Merged
gohoski merged 1 commit into
gohoski:mainfrom
Trollhunters501:patch-1
Aug 2, 2026
Merged

Set install location to auto for better storage management#25
gohoski merged 1 commit into
gohoski:mainfrom
Trollhunters501:patch-1

Conversation

@Trollhunters501

Copy link
Copy Markdown
Contributor

Added 'android:installLocation' attribute to the manifest. To allow devices with limited storage to move the application to the SD card.

Added 'android:installLocation' attribute to the manifest.
To allow devices with limited storage to move the application to the SD card.
@gohoski

gohoski commented Aug 2, 2026

Copy link
Copy Markdown
Owner

@Trollhunters501 I'm curious--what sort of device will not have 1MB of free space? 😄

@Trollhunters501

Copy link
Copy Markdown
Contributor Author

@Trollhunters501 I'm curious--what sort of device will not have 1MB of free space? 😄

There might be a few; some users might want to move it to the SD card, so we should give them the option to do so 😅

@gohoski
gohoski merged commit 37c245d into gohoski:main Aug 2, 2026
1 check passed
@Trollhunters501

Copy link
Copy Markdown
Contributor Author

I also have a question, @gohoski : can YouTube live streams be played?

@Trollhunters501
Trollhunters501 deleted the patch-1 branch August 2, 2026 15:24
@gohoski

gohoski commented Aug 2, 2026

Copy link
Copy Markdown
Owner

@Trollhunters501 no, I will add the support for them myself at some point of time. Currently notPipe expects a single video file that already has an audio track, while YouTube gives live streams only as separate video and audio tracks (files) to save space and processing power. Building a player that puts the video stream into VideoView (which is just MediaPlayer with built-in UI controls for videos) and plays the audio stream in MediaPlayer and somehow synchronizes them together would be cool but extremely prone to failure. In fact, YouTube already has separate video and audio streams for all non-360p qualities on normal videos, but notPipe utilizes yt2009 that joins those two streams together into one video file. That can't be done on the backend side for live streams. Maybe I will implement it but only as an experimental feature as there definitely will be synchronization issues. MediaPlayer in itself is extremely buggy, you can take a look at VideoActivity to see how many workarounds I have to do to maintain compatibility with every device. So I don't think I'll be able to stably implement live streams.

I need to add a check to reject playing live streams (although the client can show information about a live stream)

@Trollhunters501

Copy link
Copy Markdown
Contributor Author

Ho, ok 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants