Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add XSRFkey valication of 32 chars #1853

Closed
wants to merge 1 commit into from
Closed

add XSRFkey valication of 32 chars #1853

wants to merge 1 commit into from

Conversation

MinerYang
Copy link
Collaborator

fix: #1847

@MinerYang
Copy link
Collaborator Author

MinerYang commented Nov 20, 2024 •
edited
Loading

By leverage the benefit of the error handling , we decided to handle the error from the harbor-core runtime since helm has limitation to throw the validation error prior the installation , and it is more reasonable to having this error back to client instead of randomly generate ones for customer when the CSRF key mistakenly specified without 32 chars.

It is improved at the OSS Harbor side per this PR goharbor/harbor#21154.

So I would like to close this PR and raise another one for adding comments in values.yaml file

@MinerYang MinerYang closed this Nov 20, 2024
@MinerYang MinerYang mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vad1mo Vad1mo Vad1mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm install should check the length of the specified csrf key
2 participants
@MinerYang @Vad1mo