feature: added namespace helper

[Bugs5382]

So I am working on a project that puts Harbor inside the same namespace as the project, instead of being in default. I was looking trhough the helm chart and noticed that there was no way to override the namespace. Thus, I wrote this up. I tested it locally, and everything seems to be working A-OK!

Thanks!!!

[Vad1mo]

@Bugs5382 the your PR does not have a valid DCO

[Bugs5382]

@Vad1mo Completed. Sorry about that.

[MinerYang]

Hi @Bugs5382 ,

Would explicitly specify the namespace while you installing satisfy your requirements? like...

helm install harbor ... -n test

[reasonerjt]

Per latest comment by @MinerYang
This PR probably should not be merged into upstream.
I'm blocking this PR until we have better clarity.

[Bugs5382]

Per latest comment by @MinerYang This PR probably should not be merged into upstream. I'm blocking this PR until we have better clarity.

So the reason why I request this change as if your doing a helm template output, even specifying the namespace, the default one gets applied. Which is kinda hard when I am using this chart with krustomize and everything else. I updated the chart.

[Bugs5382]

Compelted.

[MinerYang]

Hi @Bugs5382 ,
I understood this is a limitation from helm. Thanks for your contribution!

[MinerYang]

Hi @Bugs5382 ,

Another thing may need your help and we would appreciate if you could add some UT test cases including this changes here:
https://github.com/goharbor/harbor-helm/tree/main/test/unittest.

[Bugs5382]

@MinerYang I'll check it out today!

[Kajot-dev]

What is the purpose of overriding a namespace? My question is: Is there a situation where you want to have a different release namespace than an actual install namespace?

[Vad1mo]

So the reason why I request this change as if your doing a helm template output, even specifying the namespace, the default one gets applied. Which is kinda hard when I am using this chart with krustomize and everything else. I updated the chart.

we are too running helm template . and I don't see that behavior, instead I see correct namespaces.

[Kajot-dev]

So the reason why I request this change as if your doing a helm template output, even specifying the namespace, the default one gets applied. Which is kinda hard when I am using this chart with krustomize and everything else. I updated the chart.

we are too running helm template . and I don't see that behavior, instead I see correct namespaces.

Running helm template . with the -n/--namespace option works for me too

[vpechor]

What is the purpose of overriding a namespace? My question is: Is there a situation where you want to have a different release namespace than an actual install namespace?

In our environment, we use strict GitOps approach using ArgoCD. Most of installed applications are templated using helm template command which does not offer the possibility to use .Release variables as helm install does. Using -n/--namespace is an option for small projects, but is not viable for bigger helm charts, where each module gets its own namespace (e.g. when using umbrella helm chart).
Additionally using ArgoCD to use helm install is an option, but not preferred for bigger projects as there's no direct control of what gets to production and has introduced us to some nasty bugs in production in the past (which is of course user issue).

namespaceOverride would be greatly appreciated.