Add entry for ingress.className in README
#1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saip92, the DCO is missing |
saip92
force-pushed
the
saip92/add-ingress-class-name-in-readme
branch
from
9846f84 to
842ac60
Compare
Sorry about that. Fixed it. |
|
please sync the latest changes to make the ci pass, thanks. |
|
Hi @saip92 , |
saip92
force-pushed
the
saip92/add-ingress-class-name-in-readme
branch
from
842ac60 to
0500fbe
Compare
Signed-off-by: Pramod Valavala <[email protected]>
|
@wy65701436 @MinerYang Apologies! I've been caught up recently and couldn't get to this sooner. Rebased and pushed. |
Vad1mo
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ingress.classNamevalue is supported and used by the chart but is missing from the README. This PR adds it to the configuration table.