Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom secret keys #1434

Closed
wants to merge 16 commits into from
Closed

Allow custom secret keys #1434

wants to merge 16 commits into from

Conversation

PKizzle
Copy link

@PKizzle PKizzle commented Mar 3, 2023 •
edited
Loading

Builds on top of #1326 and provides even more configuration options for secrets. Instead of enforcing default secret keys they can now be altered in order to use pre-existing secrets.

Signed-off-by: Philipp Kolberg [email protected]

PKizzle added 7 commits March 3, 2023 20:12
@PKizzle
Allow usage of existingSecret for database
c73ca7a 
If provided uses username and password in database.external.existingSecret instead of raw credentials

Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Allow usage of existing secret for redis
ea3da39 
Instead of using the redis.external.password use REDIS_PASSWORD inside redis.external.existingSecret if provided

Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Allow custom keys for secrets
2e0ad98 
Instead of using fixed keys that the user must set in order for the config to work give the user the choice to change the keys. This allows the project to use automatically generated secrets that the user is unable to update.

Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Use default values for cert secret
a8acabb 
Defaults should be fine for this kind of secret in order to reduce complexity

Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Add custom secret key specification where missing
53e626f 
Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Remove custom secret key specification for ca certs
a02e7b9 
The default key ca.crt should be fine for most use-cases. Also this improves the naming scheme.

Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Fix wrong uaaSecretName default value
e0d609b 
Signed-off-by: Philipp Kolberg <[email protected]>
zyyw
zyyw reviewed Mar 9, 2023
View reviewed changes
values.yaml Outdated Show resolved Hide resolved
zyyw
zyyw reviewed Mar 9, 2023
View reviewed changes
templates/core/core-dpl.yaml Outdated Show resolved Hide resolved
PKizzle added 6 commits April 13, 2023 05:17
@PKizzle
Merge branch 'master' of github.com:goharbor/harbor-helm into 1013-al…
1079991 
…low-custom-secret-keys

Signed-off-by: Philipp Kolberg <[email protected]>

# Conflicts:
#	templates/_helpers.tpl
@PKizzle
Re-add missing secret items for auth-ca-cert
ce8e201 
Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Adjust formatting of secret keys
efde076 
Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Remove section mentioning chartmuseum
517fe8a 
Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Re-add missing s3 and azure secret key sections
ceeb717 
Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Fix generation of redis URL
91ff678 
Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle PKizzle requested a review from zyyw April 13, 2023 15:33
@cdemers
Copy link

cdemers commented May 25, 2023 •
edited
Loading

Any progress on that PR? It would really help users of ArgoCD, as ArgoCD provides a valuable synchronisation status between what's deployed and what's not. Having the xsrf regenerated every time we render the Helm template makes it so that it's either always out of sync, or always synchronizing, which is usually not practical.

Sorry about the confusion, this was ment for #1373 .

@PKizzle
Copy link
Author

PKizzle commented May 25, 2023

Currently blocked by #1326 which needs to be merged first

@cdemers
Copy link

cdemers commented May 25, 2023

Thanks for the quick followup. I think I might have actually been looking at the wrong PR, 1373 seems to take care of the XSRF token. Sorry for the noise, and also thanks for contributing.

PKizzle added 3 commits August 7, 2023 23:45
@PKizzle
Ignore macOS temp files
5754bfb 
Signed-off-by: Philipp Kolberg <[email protected]>
@PKizzle
Merge branch 'master' into 1013-allow-custom-secret-keys
aad6f20 
Signed-off-by: Philipp Kolberg <[email protected]>

# Conflicts:
#	templates/core/core-dpl.yaml
#	values.yaml
@PKizzle
Remove dangling closing bracket
a570c97 
Signed-off-by: Philipp Kolberg <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Feb 8, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions bot closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hper4278 hper4278 hper4278 approved these changes

@zyyw zyyw Awaiting requested review from zyyw

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PKizzle @cdemers @zyyw @hper4278