Merge pull request ClickHouse#606 from ClickHouse/issue_592

Error if no address

clickhouse.go

@@ -44,6 +44,7 @@ var (
 	ErrAcquireConnTimeout        = errors.New("clickhouse: acquire conn timeout. you can increase the number of max open conn or the dial timeout")
 	ErrUnsupportedServerRevision = errors.New("clickhouse: unsupported server revision")
 	ErrBindMixedParamsFormats    = errors.New("clickhouse [bind]: mixed named, numeric or positional parameters")
+	ErrAcquireConnNoAddress      = errors.New("clickhouse: no valid address supplied")
 )
 
 type OpError struct {
@@ -199,6 +200,9 @@ func (ch *clickhouse) dial(ctx context.Context) (conn *connect, err error) {
 			return conn, nil
 		}
 	}
+	if err == nil {
+		err = ErrAcquireConnNoAddress
+	}
 	return nil, err
 }
 

tests/issues/592_test.go

@@ -0,0 +1,17 @@
+package issues
+
+import (
+	"context"
+	"github.com/ClickHouse/clickhouse-go/v2"
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func Test592(t *testing.T) {
+	conn, err := clickhouse.Open(&clickhouse.Options{})
+	assert.NoError(t, err)
+
+	ctx := context.Background()
+	err = conn.Exec(ctx, "DROP TABLE test_connection")
+	assert.Error(t, err)
+}