-
-
Notifications
You must be signed in to change notification settings - Fork 23.9k
Fix scons compability on enabling C++ 20 module
#107200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OzelotVanilla
wants to merge
4
commits into
godotengine:master
Choose a base branch
from
OzelotVanilla:fix-scons-compability-on-module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−3
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| #!/usr/bin/env python | ||
| import os | ||
| import subprocess | ||
|
|
||
| import methods | ||
|
|
||
| is_able_to_use_module_cache = None | ||
|
|
||
|
|
||
| def try_use_cxx20_module(env): | ||
| """ | ||
| Use C++20's `module` if current compiler supports that. | ||
| Referencing https://en.cppreference.com/w/cpp/compiler_support/20. | ||
| """ | ||
| global is_able_to_use_module_cache | ||
|
|
||
| if is_able_to_use_module_cache is not None: | ||
| return is_able_to_use_module_cache | ||
| else: | ||
| is_able_to_use_module_cache = True | ||
|
|
||
| # According to the reference, currently (06/03/2025, mm/dd/yyyy), | ||
| # only msvc has full support of module. | ||
| if env.msvc and is_msvc_support_module(env): | ||
| env.Append(CCFLAGS=["/experimental:module"]) | ||
| # Apple clang also supports module. | ||
| elif methods.using_clang(env) and is_clang_support_module(): | ||
| env.Append(CCFLAGS=["-fmodules", "-fcxx-modules"]) | ||
| else: | ||
| is_able_to_use_module_cache = False | ||
|
|
||
|
|
||
| def is_msvc_support_module(env) -> bool: | ||
| """ | ||
| MSVC supports C++ modules after 19.2.8. | ||
| """ | ||
| # Only "major", "minor", and "patch" has int type. | ||
| version = methods.get_compiler_version(env) | ||
| major: int = version["major"] | ||
| minor: int = version["minor"] | ||
| patch: int = version["patch"] | ||
|
|
||
| return major > 19 or (version["major"] == 19 and minor >= 2) or (major == 19 and minor == 2 and patch >= 8) | ||
OzelotVanilla marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
| def is_clang_support_module() -> bool: | ||
| """ | ||
| Check if the clang is Apple clang. | ||
| """ | ||
| env = os.environ.copy() | ||
| env["LC_ALL"] = "C" | ||
| version_text: str = subprocess.check_output(["clang", "--version"], env=env, encoding="utf-8") | ||
| return "Apple clang version" in version_text | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.