Skip to content

Add check to validate that the correct directory access has been granted #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syntaxerror247 merged 1 commit into from
Jul 19, 2026
Merged

Add check to validate that the correct directory access has been granted #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/main/java/org/godotengine/godot_gradle_build_environment/BuildEnvironment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,13 @@ class BuildEnvironment(private val context: Context, private val rootfs: String,

projectTreeUri = waitForDirectoryAccess(DIR_ACCESS_WAIT_DURATION)
?: throw Exception("Directory access not granted in time. Build canceled.")
outputHandler(OUTPUT_INFO, "Access granted for $projectPath.\nStarting Gradle build...")

if (!FileUtils.isValidDirSelected(context, projectTreeUri)) {
throw Exception("The selected folder is not a valid project directory. Please try exporting again and select $projectPath." +
"\nIf the problem persists, please create a bug report at [color=#3182CE][url]https://github.com/godotengine/android-editor-buildenv-app/issues[/url][/color]")
}

outputHandler(OUTPUT_INFO, "Access granted for project directory. Starting Gradle build...")
FileUtils.saveProjectTreeUri(context, projectPath, projectTreeUri)

// Notify user if limit is reached so they can clear older projects.
Expand Down
9 changes: 9 additions & 0 deletions app/src/main/java/org/godotengine/godot_gradle_build_environment/FileUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.content.Context
import android.content.Intent
import android.net.Uri
import android.os.Build
import android.provider.DocumentsContract
import android.util.Log
import androidx.documentfile.provider.DocumentFile
import java.io.File
Expand Down Expand Up @@ -194,4 +195,12 @@ object FileUtils {
val uriString = prefs.getString(projectPath, null)
return uriString?.toUri()
}

fun isValidDirSelected(context: Context, projectTreeUri: Uri): Boolean {
val treeDocumentId = DocumentsContract.getTreeDocumentId(projectTreeUri) ?: return false
// Check if "project.godot" file exists.
val projectGodotUri = DocumentsContract.buildDocumentUriUsingTree(projectTreeUri, "$treeDocumentId/project.godot")
val godotFile = DocumentFile.fromSingleUri(context, projectGodotUri)
return godotFile?.exists() == true
}
}
Loading