Repository navigation
Fix invalid project tree copy - #28
Merged
Merged
Conversation
Building a second project after completing the build of the first one without restarting GABE would cause the second build to incorrectly use the project tree uri from the first build, resulting in an invalid binary being generated. This is resolved by resetting the value of `grantedTreeUri` after returning it. In addition, when retrieving a projec tree uri from the shared preferences, we validate that it's still valid before using it.
syntaxerror247
approved these changes
May 26, 2026
syntaxerror247
pushed a commit
to syntaxerror247/android-editor-buildenv-app
that referenced
this pull request
May 27, 2026
Fix invalid project tree copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building a second project after completing the build of the first one without restarting GABE would cause the second build to incorrectly use the project tree uri from the first build, resulting in an invalid binary being generated.
This is resolved by resetting the value of
grantedTreeUriafter returning it.In addition, when retrieving a project tree uri from the shared preferences, we validate that it's still valid before using it.