-
-
Notifications
You must be signed in to change notification settings - Fork 224
Wasm threading fixes #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm threading fixes #1093
Conversation
6774535
to
267c573
Compare
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1093 |
1 similar comment
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1093 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
e7fdeb7
to
09dc8b8
Compare
News:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, thanks!
Spontaneous thought, since That way, it would be clearer to users that they can't just specify literals. Or would that complicate fetching the value? |
09dc8b8
to
fedbc24
Compare
Nope, did not. Just changed it and seems to work nicely. Thanks for the suggestion! I considered making it a |
fedbc24
to
fd752ba
Compare
Been testing locally, worth mentioning. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Currently implemented:
Adds custom wasm binary name support proposed in WebAssembly support #438 (comment), sample usage:
Fixes
wasm_nothreads
compilation by not using compiled out function inasync_runtime.rs
(regression from Async Signals #1043)Fixes
wasm_nothreads
runtime errors on init due to thread locals being used for panic handling (regression from Panic handling: thread safety; set hook once and not repeatedly #1037)TODO
Working on these, but feel free to review or merge what's already there.
Potentially fix the rest ofLet's do that in a separate PR (edit: using that function is actually fine, let's keep an eye on it in case anything else could be a problem)async_runtime
to e.g. not usestd::thread::current
on nothreads builds (might need to be in a separate PR.threads.wasm
when it still uses the crate name to avoid having to use the option introduced above outside atypical cases