Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple mouse plugin #723

Open
wants to merge 14 commits into
base: godot4/new-interpreter-and-savegames
Choose a base branch
from

Conversation

StraToN
Copy link
Collaborator

@StraToN StraToN commented Feb 2, 2025

Full revamp of the UI.
Still not the best, having to mousewheel through actions is not the best.

@StraToN StraToN changed the base branch from develop to godot4/new-interpreter-and-savegames February 2, 2025 16:19
@BHSDuncan
Copy link
Collaborator

Question: If I mousewheel to, say, the "look" action (the eye), and I mouse over the button in room 2, the action automatically changes to what I'm assuming is the default action for that button, in this case, the "use" action (the wrench). Is this on purpose?

Also, if I hover over the inventory while I'm in windowed mode, and I move the mouse off the edge of the game window (while still over the inventory panel), the inventory panel is stuck in the raised position until I mouse back over and move the mouse off of the panel to a non-inventory panel area of the game window.

@BHSDuncan
Copy link
Collaborator

The actions behave better now. Nice!

The "hover over inventory" issue I mentioned in my previous comment still exists, though. Can it be fixed?

One other thing I've noticed (likely unrelated to the simple mouse fixes you're doing): esc_game.gd lines 58, 59, and 60 produce an error when trying to connect three signals that are already connected to their respective handlers. This happens when starting a new game (i.e. using F5 to start and selecting "New Game").

+ cursor back to cross when unhovering inventory item
@StraToN
Copy link
Collaborator Author

StraToN commented Feb 10, 2025

@BHSDuncan I forgot your comment regarding inventory close. Fixed.
I also fixed the cursor not getting back to "walk" icon when unhovering inventory item.

@BHSDuncan
Copy link
Collaborator

BHSDuncan commented Feb 11, 2025

@StraToN If I run room 1 directly (F6), I get a crash on startup: esc_item.gd#L637. Screenshot below:

image

@StraToN
Copy link
Collaborator Author

StraToN commented Feb 12, 2025

Strange. Ok I'll check this tonight. Thanks!
edit: should be fixed now.

@StraToN StraToN force-pushed the godot4/fix-simple-mouse branch from 0e1d5c4 to 882bf2a Compare February 12, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants