Skip to content

Ensure that no fatal error occurs while processing a subscription renewal when the object is stored in the subscription's metadata. #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmolham-godaddy merged 2 commits into from
Feb 18, 2025
Merged

Ensure that no fatal error occurs while processing a subscription renewal when the object is stored in the subscription's metadata. #733

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71346e8
Fix the fatal error that occurs while processing a subscription renew…
iamdharmesh Feb 3, 2025
1564dcb
use strict comparison in `in_array` check.
iamdharmesh Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ce/payment-gateway/integrations/class-sv-wc-payment-gateway-integration-subscriptions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ public function do_not_copy_order_meta( $order_meta ) {
foreach ( (array) $order_meta as $index => $meta ) {

// this accounts for different versions of the Subscriptions filter running before and after WooCommerce Subscriptions 2.5
if ( in_array( $index, $meta_keys ) || ( isset( $meta['meta_key'] ) && in_array( $meta['meta_key'], $meta_keys ) ) ) {
if ( in_array( $index, $meta_keys, true ) || ( is_array( $meta ) && isset( $meta['meta_key'] ) && in_array( $meta['meta_key'], $meta_keys, true ) ) ) {
unset( $order_meta[ $index ] );
}
}
Expand Down
Loading