Skip to content

Add bash completion for array element addition and removal #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Mar 7, 2025

This allows bash completing things like --set witness.yaml.entry-types[+] to offer a list of valid things to add or remove (with [-]) from the list.

Copy link
Member

@michael-schwarz michael-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't have argument completion set up, so I didn't test it. However, it seems like an innocent local thing we should probably just merge.

@sim642 sim642 requested a review from karoliineh April 7, 2025 08:59
@arkocal arkocal self-assigned this May 9, 2025
@arkocal
Copy link
Contributor

arkocal commented May 9, 2025

Works fine on my system.

@sim642 sim642 added this to the v2.6.0 milestone May 11, 2025
@sim642 sim642 merged commit 0e6b597 into master May 11, 2025
23 of 27 checks passed
@sim642 sim642 deleted the arg-complete-array branch May 11, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants